[PATCH] D113557: [CMake] Allow passing extra options to extract_symbols.py.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham added a comment.

I'm not sure it //really// makes sense to be able to override the output file location in the context of a build system – surely if you want to do that, you also have to tell cmake to change the OUTPUT parameter of the custom command, or the build products won't end up where the next build step expects them! Perhaps I should move this to after --mangling, though.

I agree about FLAGS being more futureproof than TOOLS. (Plus, if you have a TOOLS definition then you have to do some extra cmake messing about to decide whether to add a --tools option at all, in the likely case that you just wanted the default).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113557/new/

https://reviews.llvm.org/D113557