[PATCH] D113557: [CMake] Allow passing extra options to extract_symbols.py.

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 02:26:02 PST 2021


DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.

Given that the only flag not specified already is `--tools` would it make more sense to have `LLVM_EXTRACT_SYMBOLS_TOOLS`?

My own answer to that is "sods law some other flag is added later and we need another cmake var". So you could at least put the extra flags on the end of the `COMMAND`. Then even though the one flag you'll usually want is `--tools` you could override the mangling or export location if you wanted to. 
(plus extra flags winning over the defaults makes more sense in general)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113557/new/

https://reviews.llvm.org/D113557



More information about the llvm-commits mailing list