[PATCH] D113557: [CMake] Allow passing extra options to extract_symbols.py.

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 03:30:49 PST 2021


DavidSpickett added a comment.

(further to some internal discussion about argparse having issues when you place these extra flags in certain positions)

What you could do is keep it as it is and update the help text of the variable to note that it will not override anything already chosen by the build system. Seems fair since like you said you'd have to make other cmake changes to account for that if it did.

So it's more "extra flags" than flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113557/new/

https://reviews.llvm.org/D113557



More information about the llvm-commits mailing list