[PATCH] D113827: [X86] Enable use of 128/256-bit VPTERNLOG on non-VLX targets

Sat Nov 13 17:08:34 PST 2021

pengfei added a comment.

> Enable use of 128/256-bit VPTERNLOG on non-VLX targets

I think the title is misleading. We widen to 512-bit VPTERNLOG rather than use 128/256-bit. Besides, should be better to mention the broadcastable work there?

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:46266-46269
+    // VPTERNLOG is only available as vXi32/64-bit types.
+    MVT OpSVT = EltSizeInBits == 32 ? MVT::i32 : MVT::i64;
+    MVT OpVT =
+        MVT::getVectorVT(OpSVT, VT.getSizeInBits() / OpSVT.getSizeInBits());
----------------
Why do we need to do it? Do we have new `VT` type other than `i32/i64` now? Or the previous code can handle them already?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113827/new/

https://reviews.llvm.org/D113827