[PATCH] D113492: [llvm-profgen] Fix bug of split range branch sample

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 10:46:33 PST 2021


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:380-381
 
+  if (StartOffset > NextStartOffset)
+    return true;
+
----------------
wenlei wrote:
> Moving this check is for printing symbols with zero size, right? 
> 
> What symbols have zero size?
Yes, all is due to the alias issues.  Those are two type: 1)C1 vs C2  2) undemangled symbol

```
zero-size: _ZN5boost6threadC1Ev
<_ZN5boost6threadC2Ev>:
```

```
zero-size: numa_set_membind_v2
<numa_set_membind_v2_int>:
```
See they are all right followed by their non-zero size alias.

But but not vice versa, remembering one of C1 or C2 can't be removed.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113492/new/

https://reviews.llvm.org/D113492



More information about the llvm-commits mailing list