[PATCH] D113492: [llvm-profgen] Fix bug of split range branch sample

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:380-381
 
+  if (StartOffset > NextStartOffset)
+    return true;
+
----------------
wlei wrote:
> wenlei wrote:
> > Moving this check is for printing symbols with zero size, right? 
> > 
> > What symbols have zero size?
> Yes, all is due to the alias issues.  Those are two type: 1)C1 vs C2  2) undemangled symbol
> 
> ```
> zero-size: _ZN5boost6threadC1Ev
> <_ZN5boost6threadC2Ev>:
> ```
> 
> ```
> zero-size: numa_set_membind_v2
> <numa_set_membind_v2_int>:
> ```
> See they are all right followed by their non-zero size alias.
> 
> But but not vice versa, remembering one of C1 or C2 can't be removed.
> 
> 
On the second thought, what does this check do? I thought symbols are sorted based on their start offset before disassembled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113492/new/

https://reviews.llvm.org/D113492