[PATCH] D113492: [llvm-profgen] Fix bug of split range branch sample

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

The change description needs to be updated too.



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:177
+      if (ShowDetailedWarning)
+        WithColor::warning() << "Function " + F.first + " has no entry range\n";
+    }
----------------
This warning is a bit confusing.. Technically there's no such thing as function doesn't have an entry. How about this: Failed to determine function entry for xxx due to inconsistent name from symbol table and dwarf info. 


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:380-381
 
+  if (StartOffset > NextStartOffset)
+    return true;
+
----------------
Moving this check is for printing symbols with zero size, right? 

What symbols have zero size?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113492/new/

https://reviews.llvm.org/D113492