[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`
Eric Schweitz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 9 07:05:27 PST 2021
schweitz added inline comments.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:77
+// Create value signaling an absent optional argument in a call, e.g.
+// `fir.absent !fir.ref<i64>` --> `llvm.mlir.null : !llvm.ptr<i64>`
+struct AbsentOpConversion : public FIROpConversion<fir::AbsentOp> {
----------------
Should we be writing doxygen comments?
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:579
+ pattern
+ .insert<AbsentOpConversion, AddrOfOpConversion, CallOpConversion,
+ ExtractValueOpConversion, HasValueOpConversion,
----------------
Different version of clang-format?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113395/new/
https://reviews.llvm.org/D113395
More information about the llvm-commits
mailing list