[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski marked an inline comment as done.
awarzynski added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:77
+// Create value signaling an absent optional argument in a call, e.g.
+// `fir.absent !fir.ref<i64>` -->  `llvm.mlir.null : !llvm.ptr<i64>`
+struct AbsentOpConversion : public FIROpConversion<fir::AbsentOp> {
----------------
schweitz wrote:
> Should we be writing doxygen comments?
Let me fix that!


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:579
+    pattern
+        .insert<AbsentOpConversion, AddrOfOpConversion, CallOpConversion,
+                ExtractValueOpConversion, HasValueOpConversion,
----------------
schweitz wrote:
> Different version of clang-format?
Not necessarily. IIRC, clang-format has no hard rules for where to break lines. But I couldn't find a definitive answer. 

I use clang-format-13. Pre-commit CI seems happy. Shall we leave it like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113395/new/

https://reviews.llvm.org/D113395