[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:86
+    mlir::Type ty = convertType(absent.getType());
+    mlir::Location loc = absent.getLoc();
+
----------------
awarzynski wrote:
> clementval wrote:
> > Fine if you want to update `auto` usage from `fir-dev` here. `getLoc()` is most of the time used with `auto` even in MLIR code base. 
> > 
> > Don't forget to sync back in fir-dev. 
> > Don't forget to sync back in fir-dev.
> 
> I've made similar changes elsewhere as well. Let me send them to `fie-dev` as one bigger patch (to minimise the traffic). Shall I do it once all of the conversions in this file are complete?
If they are just typos/auto or stuff like that you can submit them later. If it's smth like rewriting a block of code or refactoring it's good if we don't loos track of the change. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113395/new/

https://reviews.llvm.org/D113395