[PATCH] D113241: [lld-macho][nfc] rename parsed-section types & variables

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 7 07:13:35 PST 2021


gkm added a comment.

In D113241#3113825 <https://reviews.llvm.org/D113241#3113825>, @int3 wrote:

> Not a huge fan of the `Parsed` stuff either, I don't think there's much confusion about when we are working with parsed vs serialized structures...

Prepending `Parsed` was a late change and I'm OK with reversing it. My concern was that `Section` is misleading, since it is not a base class of `InputSection` or `OutputSection` as the name might suggest. No big deal though. The more important change was s/`Section`/`SectionHeader`/ for the template arg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113241/new/

https://reviews.llvm.org/D113241



More information about the llvm-commits mailing list