[PATCH] D113241: [lld-macho][nfc] rename parsed-section types & variables
Greg McGary via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 6 17:33:53 PDT 2021
gkm added a comment.
In D113241#3113825 <https://reviews.llvm.org/D113241#3113825>, @int3 wrote:
> The Map instead of Vec thing was intentional... a vector of pairs is semantically a map.
I was thinking of "map" operationally, i.e., used for associative lookups.
> Not a huge fan of the `Parsed` stuff either, I don't think there's much confusion about when we are working with parsed vs serialized structures...
That sounds like mitigated speech for "veto". Correct me if I misinterpret.
> As for the `offset` member... seems kind of hard to evaluate it without the context of the `__eh_frame`.
FYI, it morphed into an `address` member. I'll put-up a new `__eh_frame` diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113241/new/
https://reviews.llvm.org/D113241
More information about the llvm-commits
mailing list