[PATCH] D113241: [lld-macho][nfc] rename parsed-section types & variables

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 7 11:55:35 PST 2021


thevinster added a comment.

I'm a big fan of the variable names switching from s/subsections/sections, s/subsectionMap/subsections. It's clearer to me that there are layers whereas the original subsections->subsectionMap layer is not as easily decipherable. Section->SectionHeader makes sense to me, but I would like it if we had some consistency, which means also renaming SegmentCommand->SegmentCommandHeader, NList->NListHeader, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113241/new/

https://reviews.llvm.org/D113241



More information about the llvm-commits mailing list