[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added a comment.

In D113179#3108451 <https://reviews.llvm.org/D113179#3108451>, @lebedev.ri wrote:

> Isn't it just a symptom that said passes need to be enhanced?
> They will still not handle the 'bad' patterns even if AIC no longer produces them beforehand.

That's definitely a symptom, sure. I've waited some time to gather unveiled issues and going to wait more till all of them seem reported and fixed. But I still believe this change should be ever committed.

> Is there anything in the commit logs or patch reviews that explains why AIC was put before instcombine in the pipeline?

I've passed through the long story of its review (D38313 <https://reviews.llvm.org/D38313>) and haven't seen special attention to this point. Initially AIC was implemented as a part of InstCombine, running _before_ its iterations of pattern-matching, but it was splitted out to separate pass in a process of review (https://reviews.llvm.org/D38313#906667).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113179/new/

https://reviews.llvm.org/D113179