[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D113179#3108672 <https://reviews.llvm.org/D113179#3108672>, @anton-afanasyev wrote:

>> Is there anything in the commit logs or patch reviews that explains why AIC was put before instcombine in the pipeline?
>
> I've passed through the long story of its review (D38313 <https://reviews.llvm.org/D38313>) and haven't seen special attention to this point. Initially AIC was implemented as a part of InstCombine, running _before_ its iterations of pattern-matching, but it was splitted out to separate pass in a process of review (https://reviews.llvm.org/D38313#906667).

Thanks for digging that up. I don't see any reason that it was placed that way either, so LGTM. Please wait to see if @lebedev.ri agrees though.

We should update/file bugs for the regressions that were uncovered by the previous AIC change, so they are independent of -O3/AIC and we don't lose those. Do you know if there others -- apart from the ones listed in the summary: PR52078 (fixed), PR52253 (in progress), PR52289 (updated/forked) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113179/new/

https://reviews.llvm.org/D113179