[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D113179#3108451 <https://reviews.llvm.org/D113179#3108451>, @lebedev.ri wrote:

> Isn't it just a symptom that said passes need to be enhanced?
> They will still not handle the 'bad' patterns even if AIC no longer produces them beforehand.

I agree (and I put an instcombine fold candidate in PR52289), but I also think this is a good change. 
AIC isn't generally expecting non-canonical IR, so it could be missing transforms if it encounters weird IR (for example, a commutative binop with constant as operand 0).
Is there anything in the commit logs or patch reviews that explains why AIC was put before instcombine in the pipeline?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113179/new/

https://reviews.llvm.org/D113179