[PATCH] D113090: [flang][CodeGen] Transform `fir.{store|load}` to `llvm.{store|load}`

Wed Nov 3 10:46:09 PDT 2021

awarzynski added a comment.

In D113090#3105647 <https://reviews.llvm.org/D113090#3105647>, @clementval wrote:

> In D113090#3105615 <https://reviews.llvm.org/D113090#3105615>, @kiranchandramohan wrote:
>
>> So does @awarzynski have to bring in the `convertBoxType` function?
>
> Or it will come with D112961 <https://reviews.llvm.org/D112961> if anyone review it.

Tl;Dr Perhaps we should just add more tests later?

Longer version - I've tried applying D112961 <https://reviews.llvm.org/D112961>, but that didn't work. It depends on 2 other patches, so perhaps I wasn't applying it correctly? I've just tried my usual `arc patch D112961`. Regardless, if we prefer to have all tests added in one patch then I can set the dependencies accordingly and re-visit `arc patch`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113090/new/

https://reviews.llvm.org/D113090