[PATCH] D113090: [flang][CodeGen] Transform `fir.{store|load}` to `llvm.{store|load}`

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/test/Fir/convert-to-llvm.fir:156
+// CHECK-NEXT:    llvm.return
+// CHECK-NEXT:  }
+
----------------
In general: please use CHECK-LABEL for delimiting the test (that helps FileCheck, in particular the print in case of failure is much friendlier) and minimize the checks, while capturing what matters (here I suspect types and argument flowing in the right place it what you're checking (I think that's also what Kiran hinted at):

```
// CHECK-LABEL: llvm.func @test_store
// CHECK-SAME: %[[ARG0:.*]]: <type here>, %[[ARG1:.*]]: <type here>
// CHECK:    llvm.store %[[ARG0]], .....
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113090/new/

https://reviews.llvm.org/D113090