[PATCH] D113090: [flang][CodeGen] Transform `fir.{store|load}` to `llvm.{store|load}`

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:175
+      rewriter.replaceOpWithNewOp<mlir::LLVM::LoadOp>(load, ty,
+          adaptor.getOperands(), at);
+    }
----------------
clementval wrote:
> Can you address this formatting issue?
Sorry about that :/ 


================
Comment at: flang/test/Fir/convert-to-llvm.fir:156
+// CHECK-NEXT:    llvm.return
+// CHECK-NEXT:  }
+
----------------
mehdi_amini wrote:
> In general: please use CHECK-LABEL for delimiting the test (that helps FileCheck, in particular the print in case of failure is much friendlier) and minimize the checks, while capturing what matters (here I suspect types and argument flowing in the right place it what you're checking (I think that's also what Kiran hinted at):
> 
> ```
> // CHECK-LABEL: llvm.func @test_store
> // CHECK-SAME: %[[ARG0:.*]]: <type here>, %[[ARG1:.*]]: <type here>
> // CHECK:    llvm.store %[[ARG0]], .....
> ```
> 
haha, as I was in the process of changing that :-) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113090/new/

https://reviews.llvm.org/D113090