[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo planned changes to this revision.
oontvoo added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1475
 
-    if (config->deadStrip)
-      markLive();
----------------
thakis wrote:
> We definitely want to run dead stripping before ICF (no need to spend time ICF'ing code that's dead -- dead-stripping is faster than ICFing). This doesn't lg.
Right - on the other hand,  compactUnwindEntries need to be setup before deadstripping (but it shouldn't be done before ICF ...)

Let me re-think this ... there's a cyclic depependency here.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977