[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

I don't think this has anything to do with ICF. The assert was trying to verify that any subsections associated with a coalesced weak symbol has `wasCoalesced = true`. But now I see that it's not always true, because of this FIXME: https://github.com/llvm/llvm-project/blob/main/lld/MachO/SymbolTable.cpp#L73

We could *probably* remove the assert with no ill effects; I think the only effect is that we will emit some subsections containing dead code that have their associated compact unwind info dropped. But we should ideally handle the FIXME. @oontvoo do you want to take a stab at it, or should I?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977