[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

[Nico Weber via Phabricator via llvm-commits]

thakis requested changes to this revision.
thakis added a comment.
This revision now requires changes to proceed.

This looks wrong to me.



================
Comment at: lld/MachO/Driver.cpp:1475
 
-    if (config->deadStrip)
-      markLive();
----------------
We definitely want to run dead stripping before ICF (no need to spend time ICF'ing code that's dead -- dead-stripping is faster than ICFing). This doesn't lg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977