[PATCH] D112845: [fir] Add base of the FIR to LLVM IR pass

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 09:16:15 PDT 2021


mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:95
+      // Replace insert_on_range with a constant dense attribute if the
+      // initialization is on the full range.
+      auto insertOnRangeOps = gr.front().getOps<fir::InsertOnRangeOp>();
----------------
mehdi_amini wrote:
> Isn't this something that should be a `fold()` on the insert_on_range op instead?
WDYT of this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112845/new/

https://reviews.llvm.org/D112845



More information about the llvm-commits mailing list