[PATCH] D112845: [fir] Add base of the FIR to LLVM IR pass

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 2 inline comments as done.
clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:95
+      // Replace insert_on_range with a constant dense attribute if the
+      // initialization is on the full range.
+      auto insertOnRangeOps = gr.front().getOps<fir::InsertOnRangeOp>();
----------------
mehdi_amini wrote:
> Isn't this something that should be a `fold()` on the insert_on_range op instead?
I'll look at that in a separate patch.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:95
+      // Replace insert_on_range with a constant dense attribute if the
+      // initialization is on the full range.
+      auto insertOnRangeOps = gr.front().getOps<fir::InsertOnRangeOp>();
----------------
mehdi_amini wrote:
> clementval wrote:
> > mehdi_amini wrote:
> > > Isn't this something that should be a `fold()` on the insert_on_range op instead?
> > I'll look at that in a separate patch.
> WDYT of this?
As mentioned I'll look at this and issue a separate patch since it's a somewhat bigger change than the others requested.  Keep it undone until the patch is up for review. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112845/new/

https://reviews.llvm.org/D112845