[PATCH] D112845: [fir] Add base of the FIR to LLVM IR pass
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 1 03:01:36 PDT 2021
clementval marked 4 inline comments as done.
clementval added a comment.
Addressed most of the comment in D112918 <https://reviews.llvm.org/D112918>
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:74
+
+struct GlobalOpConversion : public FIROpConversion<fir::GlobalOp> {
+ using FIROpConversion::FIROpConversion;
----------------
mehdi_amini wrote:
> I think it'd be great to document each of the conversion if possible
Added some comment for this conversion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112845/new/
https://reviews.llvm.org/D112845
More information about the llvm-commits
mailing list