[PATCH] D112692: [RISCV] Generate pseudo instruction li

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 28 07:03:01 PDT 2021


asb added a comment.
Herald added a reviewer: luke957.

Thanks for the patch!

I think it would be better to print this pseudo-instruction as you propose, and it aligns wiht what GCC does. I think the only reason RISC-V LLVM doesn't do this is that it was forgotten about.

The only real downside is of course the change is fairly disruptive in terms of test code. The in-tree tests use update_llc_test_checks wherever possible, and hopefully any downstream users are also doing this.

@jrtc27 - as someone maintaining a downstream branch, any thoughts on this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112692/new/

https://reviews.llvm.org/D112692



More information about the llvm-commits mailing list