[PATCH] D112286: Add -dwarf-inlined-strings=Disable option to DWARF tests that expect DW_FORM_strp

Jake Egan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 18:42:07 PDT 2021


Jake-Egan added a comment.

In D112286#3085048 <https://reviews.llvm.org/D112286#3085048>, @dblaikie wrote:

> I think probably generalizing the tests to not care about the string encodings is probably the right thing, rather than forcing indirect strings?
>
> I think these tests are overly specific - they don't look like they should care about the string encoding (& Probably an artifact of older techniques in writing these debug info tests - improvements to the dumper to print strings inline, skip forms, etc)

I agree generalizing the test is probably the better option if `DW_FORM_strp` isn't necessary for the purpose of the test.

@shchenz I will update the patch if you have no objection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112286/new/

https://reviews.llvm.org/D112286



More information about the llvm-commits mailing list