[PATCH] D112286: Add -dwarf-inlined-strings=Disable option to DWARF tests that expect DW_FORM_strp

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

In D112286#3086128 <https://reviews.llvm.org/D112286#3086128>, @Jake-Egan wrote:

> In D112286#3085048 <https://reviews.llvm.org/D112286#3085048>, @dblaikie wrote:
>
>> I think probably generalizing the tests to not care about the string encodings is probably the right thing, rather than forcing indirect strings?
>>
>> I think these tests are overly specific - they don't look like they should care about the string encoding (& Probably an artifact of older techniques in writing these debug info tests - improvements to the dumper to print strings inline, skip forms, etc)
>
> I agree generalizing the test is probably the better option if `DW_FORM_strp` isn't necessary for the purpose of the test.
>
> @shchenz I will update the patch if you have no objection.

Sounds good to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112286/new/

https://reviews.llvm.org/D112286