[PATCH] D112286: Add -dwarf-inlined-strings=Disable option to DWARF tests that expect DW_FORM_strp

Mon Oct 25 10:43:59 PDT 2021

dblaikie added a comment.

In D112286#3082790 <https://reviews.llvm.org/D112286#3082790>, @Jake-Egan wrote:

> Here is an example for the differing output with file llvm/test/DebugInfo/Generic/varargs.ll
>
> On Linux:
>
>   DW_AT_name [DW_FORM_strp]^I( .debug_str[0x00000065] = "a")$ 
>
> On AIX:
>
>   DW_AT_name [DW_FORM_string]^I("a")$
>
> I will create a new patch for the white space issue and convert this patch to add the `-dwarf-inlined-strings=Disable` option.

Thanks for showing the difference - I think these can probably most often be tested with `CHECK: DW_AT_name {{.*}}"a"` is probably fine - or if the tests don't need -v output (doesn't dump forms, etc), it'll probably be simpler, may even be exactly the same output between strp and str encodings.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112286/new/

https://reviews.llvm.org/D112286