[PATCH] D112464: [x86] limit vector increment fold to allow load folding

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 11:59:24 PDT 2021


spatel updated this revision to Diff 382078.
spatel marked an inline comment as done.
spatel added a comment.

Patch updated:

1. Make `mayFoldLoad` visible to X86ISelDAGToDAG and use it in the predicate.
2. Added a test with extra uses of loads, so we can see the result in that case (unchanged / negative test for this patch).

I can make the helper visibility/formatting changes an NFC pre-commit if that looks ok. We have functions like that scattered around, so it's not clear to me if there's a better way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112464/new/

https://reviews.llvm.org/D112464

Files:
  llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h
  llvm/test/CodeGen/X86/combine-sub.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112464.382078.patch
Type: text/x-patch
Size: 10943 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211025/5f8bc03d/attachment.bin>


More information about the llvm-commits mailing list