[PATCH] D112464: [x86] limit vector increment fold to allow load folding

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 11:53:29 PDT 2021


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:900
+    auto mayPreventLoadFold = [&]() {
+      return N->getOperand(0).getOpcode() == ISD::LOAD &&
+             N->getOpcode() == ISD::ADD && Subtarget->hasAVX() &&
----------------
lebedev.ri wrote:
> What about multi-use load, we usually don't load-fold those?
Yes, good point. I really want to use the same logic as in X86ISelLowering's MayFoldLoad, but it's a static function. Let me update that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112464/new/

https://reviews.llvm.org/D112464



More information about the llvm-commits mailing list