[PATCH] D112464: [x86] limit vector increment fold to allow load folding

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 12:12:08 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:5053
   // because that would narrow the load, which isn't legal for volatiles.
   const LoadSDNode *Ld = dyn_cast<LoadSDNode>(Op.getNode());
   return !Ld->isVolatile() ||
----------------
While you're in here, can you use `cast` here since the `dyn_cast` isn't checked for null.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112464/new/

https://reviews.llvm.org/D112464



More information about the llvm-commits mailing list