[PATCH] D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 21 00:09:38 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/debug-vars.yaml:1
+## Test parsing of --dwarf=frames
+
----------------
Copy/paste error.

There's already testing in ARM/debug-vars-dwarf4.yaml for the valid values for --debug-vars, so I'd just simplify by putting the error check in there.


================
Comment at: llvm/test/tools/llvm-objdump/X86/eh_frame.yaml:1
+## Test parsing of --dwarf=frames
+
----------------
I'd suggest calling this test `dwarf_frames.yaml`, since that's the switch under test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112183/new/

https://reviews.llvm.org/D112183



More information about the llvm-commits mailing list