[PATCH] D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 14:17:57 PDT 2021


gbreynoo created this revision.
gbreynoo added reviewers: MaskRay, thakis, jhenderson.
Herald added a subscriber: rupprecht.
gbreynoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As seen in https://bugs.llvm.org/show_bug.cgi?id=52213 llvm-objdump asserts if either the `--debug-vars` or the `--dwarf` options are provided with invalid values. As suggested, this fix adds use of a default value to these options and errors when given bad input.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112183

Files:
  llvm/test/tools/llvm-objdump/X86/debug-vars.yaml
  llvm/test/tools/llvm-objdump/X86/eh_frame.yaml
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112183.381094.patch
Type: text/x-patch
Size: 4180 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211020/84d53fd6/attachment.bin>


More information about the llvm-commits mailing list