[PATCH] D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/debug-vars.yaml:1
+## Test parsing of --dwarf=frames
+
----------------
jhenderson wrote:
> Copy/paste error.
> 
> There's already testing in ARM/debug-vars-dwarf4.yaml for the valid values for --debug-vars, so I'd just simplify by putting the error check in there.
To clarify further: I think the test there is just a generic test, so the fact that it's in ARM doesn't mean we need another test case for X86, since the functionality is generic.


================
Comment at: llvm/test/tools/llvm-objdump/X86/eh_frame.yaml:1
+## Test parsing of --dwarf=frames
+
----------------
jhenderson wrote:
> I'd suggest calling this test `dwarf_frames.yaml`, since that's the switch under test.
Actually, having looked at what testing there already is, I'd consider naming this dwarf_invalid.yaml, and putting it outside the X86 directory: this test contains no X86-specific functionality, so it doesn't need to be there.


================
Comment at: llvm/test/tools/llvm-objdump/X86/eh_frame.yaml:17
+  Type:    ET_REL
+  Machine: EM_X86_64
----------------
I believe you can drop the Machine line, since you're not trying to do anything that needs a target (but you might not be able to).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112183/new/

https://reviews.llvm.org/D112183