[PATCH] D111706: [lld-macho] Fix dangling string reference when adding frameworks

[Kaining Zhong via Phabricator via llvm-commits]

PRESIDENT810 updated this revision to Diff 381136.
PRESIDENT810 added a comment.

Now my test uses cp command to create framework instead of ln command. Hope this will do, and if there is any problem, please let me know so I can try other workarounds.

I also noticed that in lld/test/MachO/framework.s, it also uses ln command to create frameworks (and requires shell to disable this test on Windows). If we can use cp to create frameworks and build successfully, maybe we can modify this test by replacing ln with cp, and enable this test on Windows? I'll be glad to submit another patch about this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111706/new/

https://reviews.llvm.org/D111706

Files:
  lld/MachO/Driver.cpp
  lld/MachO/Driver.h
  lld/MachO/DriverUtils.cpp
  lld/MachO/InputFiles.cpp
  lld/test/MachO/lc-linker-option.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111706.381136.patch
Type: text/x-patch
Size: 7278 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211021/3d5a21d1/attachment.bin>