[PATCH] D111706: [lld-macho] Fix dangling string reference when adding frameworks

[Douglas Yung via Phabricator via llvm-commits]

dyung added a comment.

In D111706#3076699 <https://reviews.llvm.org/D111706#3076699>, @oontvoo wrote:

> In D111706#3076692 <https://reviews.llvm.org/D111706#3076692>, @int3 wrote:
>
>> Looking. Shouldn't be too hard to rewrite the test not to use frameworks
>
> or maybe we could just `cp` rather than doing softlink?
>
> P.S: i thought there were some windows buildbots... do they no longer run?

Our internal Windows build bot is also hitting an error on this change. We put the gnuwin32 tools on the path for it, and it appears that it only creates a shortcut since NTFS doesn't really support symbolic links. The linking command eventually fails like this:

  $ "ld64.lld" "-arch" "x86_64" "-platform_version" "macos" "10.15" "11.0" "-syslibroot" "C:/Dev/git/merge/lld/test\MachO\Inputs\MacOSX.sdk" "-fatal_warnings" "-demangle" "-ObjC" "C:\Dev\git\merge\build-ps4-test\tools\lld\test\MachO\Output\lc-linker-option.ll.tmp/objfile1.o" "C:\Dev\git\merge\build-ps4-test\tools\lld\test\MachO\Output\lc-linker-option.ll.tmp/objfile2.o" "C:\Dev\git\merge\build-ps4-test\tools\lld\test\MachO\Output\lc-linker-option.ll.tmp/main.o" "-o" "C:\Dev\git\merge\build-ps4-test\tools\lld\test\MachO\Output\lc-linker-option.ll.tmp/main.out" "-arch" "x86_64" "-platform_version" "macos" "11.0.0" "0.0.0" "-FC:\Dev\git\merge\build-ps4-test\tools\lld\test\MachO\Output\lc-linker-option.ll.tmp"
  # command stderr:
  ld64.lld: error: framework not found for -framework foo
  ld64.lld: error: framework not found for -framework foo

Maybe the cp approach would be better for Windows?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111706/new/

https://reviews.llvm.org/D111706