[PATCH] D111706: [lld-macho] Fix dangling string reference when adding frameworks

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

I went down a rabbit hole while trying to fix this, discovering two different issues with our framework loading code in the process, which I've filed in https://bugs.llvm.org/show_bug.cgi?id=52246 and https://bugs.llvm.org/show_bug.cgi?id=52247. D112195: [lld-macho] Simplify lc-linker-option.ll and re-enable it on Windows <https://reviews.llvm.org/D112195> is my follow-up diff.

As for framework.s, I would like us to keep it using symlinks, as I want to emulate a 'real' framework as closely as possible in at least one of our tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111706/new/

https://reviews.llvm.org/D111706