[PATCH] D108750: [PowerPC] common chains to reuse offsets to reduce register pressure

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

Thanks for your review. @jsji



================
Comment at: llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp:830
   for (auto &B : Buckets) {
+    if (cast<SCEVAddRecExpr>(B.BaseSCEV)->getStepRecurrence(*SE) !=
+        cast<SCEVAddRecExpr>(LSCEV)->getStepRecurrence(*SE))
----------------
jsji wrote:
> This is a new check for updateform/d/dqform, make sure it is intended.
Yes, this is required for chain common but not needed for update/d/dqform rewrite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108750/new/

https://reviews.llvm.org/D108750