[PATCH] D112093: Fixes majorOSVersion and majorSubsystemVersion being set into too large values

[Mateusz Mikuła via Phabricator via llvm-commits]

mati865 added a comment.

I never had to dig into subsystem versions and what do the mean but looking at subsystem <https://docs.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=msvc-160> docs `4.0` stands for kernel mode drivers which looks wrong to me. They also specify `5.01` as 32-bit, `5.02` as 64-bit and `6.0` as being either 32-bit or 64-bit.

I'm not sure if major OS version actually means anything but I agree `6.0` which stands for long gone Vista is reasonable. I would not mind changing it however.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112093/new/

https://reviews.llvm.org/D112093