[PATCH] D112093: Fixes majorOSVersion and majorSubsystemVersion being set into too large values

Wed Oct 20 10:47:27 PDT 2021

rnk added a comment.

In D112093#3074559 <https://reviews.llvm.org/D112093#3074559>, @mstorsjo wrote:

> I don't think the default of the main COFF linker should be lowered.
>
> But I guess one could argue whether the mingw frontend should set the default target lower - then one doesn't have to change the main default in lld/COFF/Config.h, but tweak the logic in lld/MinGW/Driver.cpp. It currently has to keep a hardcoded default version for some cases, but defaults to the COFF linker's default in some cases. We could make it always pass a version number.
>
> What do @mati865 or @jeremyd2019 think about this?

I agree, I think LLD has the right default. Both drivers have flags if you need to pick a different OS or subsystem version. If we want to change the mingw default to be lower, that seems OK to me.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112093/new/

https://reviews.llvm.org/D112093