[PATCH] D112093: Fixes majorOSVersion and majorSubsystemVersion being set into too large values

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a reviewer: rnk.
mstorsjo added subscribers: jeremyd2019, mati865, llvm-commits.
mstorsjo added a comment.

Overall, many things assume Windows 7 these days, so I don't think it's an entirely unreasonable default - you can always set a lower target if you want to, by passing e.g. `--major-os-version 4` to the linker. I don't think the default of the main COFF linker should be lowered.

But I guess one could argue whether the mingw frontend should set the default target lower - then one doesn't have to change the main default in lld/COFF/Config.h, but tweak the logic in lld/MinGW/Driver.cpp. It currently has to keep a hardcoded default version for some cases, but defaults to the COFF linker's default in some cases. We could make it always pass a version number.

What do @mati865 or @jeremyd2019 think about this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112093/new/

https://reviews.llvm.org/D112093