[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

[Nimish Mishra via Phabricator via llvm-commits]

NimishMishra added a comment.

In D110502#3058038 <https://reviews.llvm.org/D110502#3058038>, @kiranchandramohan wrote:

> I have one request for change.
>
> I think the other hint clause specific checks can come in a separate patch.

Should I revert the hint clause change from this patch?

Yes I am working on a separate patch for hint clauses. Should I move this patch's hint clause test to that one?



================
Comment at: flang/test/Semantics/omp-sync-critical02.f90:46
+   !ERROR: Hint clause cannot exist on an unnamed CRITICAL directive
+   !$omp critical hint(omp_sync_hint_none)
+   j = j + 1
----------------
kiranchandramohan wrote:
> The standard says the following and I think this is not an error.
> 
> "Unless the effect is as if hint(omp_sync_hint_none) was specified, the critical construct must specify a name."
You are right. I missed it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502