[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 05:22:36 PDT 2021


kiranchandramohan added a comment.

In D110502#3058058 <https://reviews.llvm.org/D110502#3058058>, @NimishMishra wrote:

> In D110502#3058038 <https://reviews.llvm.org/D110502#3058038>, @kiranchandramohan wrote:
>
>> I have one request for change.
>>
>> I think the other hint clause specific checks can come in a separate patch.
>
> Should I revert the hint clause change from this patch?
>
> Yes I am working on a separate patch for hint clauses. Should I move this patch's hint clause test to that one?

You can keep this hint check in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502



More information about the llvm-commits mailing list