[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added a comment.
This revision now requires changes to proceed.

I have one request for change.

I think the other hint clause specific checks can come in a separate patch.



================
Comment at: flang/test/Semantics/omp-sync-critical02.f90:46
+   !ERROR: Hint clause cannot exist on an unnamed CRITICAL directive
+   !$omp critical hint(omp_sync_hint_none)
+   j = j + 1
----------------
The standard says the following and I think this is not an error.

"Unless the effect is as if hint(omp_sync_hint_none) was specified, the critical construct must specify a name."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502