[PATCH] D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 00:30:13 PDT 2021


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

We're also hitting the error in a downstream build (https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/1808), and it reproduces for me locally.

Not sure why it doesn't happen on other Windows bots, but the workaround looks good to me, please commit :-)



================
Comment at: llvm/test/tools/llvm-cxxfilt/delimiters.test:33
+RUN:      '_Z3Foo$ ._Z3Foo' > %t
+RUN:      llvm-cxxfilt -n < %t | FileCheck %s
 
----------------
Maybe add a comment somewhere explaining why piping directly to llvm-cxxfilt doesn't work, to reduce the risk of someone "optimizing" this again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111072/new/

https://reviews.llvm.org/D111072



More information about the llvm-commits mailing list