[PATCH] D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd

Tue Oct 5 03:42:03 PDT 2021

Orlando added a comment.

In D111072#3041729 <https://reviews.llvm.org/D111072#3041729>, @jhenderson wrote:

> This looks fine as a workaround, but I have no idea why it's needed - I don't think cmd is even involved in the pipe in this case (it should just be python piping between subprocess calls, although it's been a while since I looked at the lit internals). My best guess is something to do with python versions - it would be worth checking to see if there is a difference between the downstream and upstream versions being run.
>
> FYI, there are a couple of llvm-ar tests that work with non-ascii characters, but it always writes to and then reads from a file. It might be informative to confirm whether lit is definitely the issue or not by playing with this or writing a trivial test that doesn't actually exercise any llvm tools (e.g. by piping the result of echo directly to FileCheck).
>
> Maybe worth doing some extra investigation of lit so we're not tripped up by this in the future?

In D111072#3041747 <https://reviews.llvm.org/D111072#3041747>, @hans wrote:

> We're also hitting the error in a downstream build (https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/1808), and it reproduces for me locally.
>
> Not sure why it doesn't happen on other Windows bots, but the workaround looks good to me, please commit :-)

I'll spend some time looking deeper today and write a ticket if I can't find a fix, but I'll commit this for now as a work around. Thanks all.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111072/new/

https://reviews.llvm.org/D111072