[PATCH] D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This looks fine as a workaround, but I have no idea why it's needed - I don't think cmd is even involved in the pipe in this case (it should just be python piping between subprocess calls, although it's been a while since I looked at the lit internals). My best guess is something to do with python versions - it would be worth checking to see if there is a difference between the downstream and upstream versions being run.

FYI, there are a couple of llvm-ar tests that work with non-ascii characters, but it always writes to and then reads from a file. It might be informative to confirm whether lit is definitely the issue or not by playing with this or writing a trivial test that doesn't actually exercise any llvm tools (e.g. by piping the result of echo directly to FileCheck).

Maybe worth doing some extra investigation of lit so we're not tripped up by this in the future?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111072/new/

https://reviews.llvm.org/D111072