[PATCH] D110016: Check for invalid projects passed in LLVM_ENABLE_PROJECTS

Mon Sep 20 12:11:10 PDT 2021

thakis added a comment.

In D110016#3010136 <https://reviews.llvm.org/D110016#3010136>, @mehdi_amini wrote:

> In D110016#3010053 <https://reviews.llvm.org/D110016#3010053>, @thakis wrote:
>
>> This is a problem for us (chromium). We inject an extra target at the cmake level and then pass that to LLVM_ENABLE_PROJECTS. That used to work fine, but now it's rejected.
>
> I didn't quite get the "inject" part?

Like so: https://source.chromium.org/chromium/chromium/src/+/main:tools/clang/scripts/build.py;l=192?q=chrometools&ss=chromium

> Any of these could work.

Cool, did the first version in 55f0b337087136554122f942fea951a357bc4a49 <https://reviews.llvm.org/rG55f0b337087136554122f942fea951a357bc4a49>.

> Actually we already have a flag for that: `-DLLVM_EXTERNAL_PROJECTS` which is intended to be used to declare projects that aren't "known" (see https://llvm.org/docs/CMake.html )
> Aren't you able to use this?

We tried it a while ago and ran into a bunch of issues, see https://bugs.chromium.org/p/chromium/issues/detail?id=962988&q=LLVM_EXTERNAL_PROJECTS&can=2

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110016/new/

https://reviews.llvm.org/D110016