[PATCH] D110016: Check for invalid projects passed in LLVM_ENABLE_PROJECTS

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 12:58:49 PDT 2021


mehdi_amini added a comment.

In D110016#3010192 <https://reviews.llvm.org/D110016#3010192>, @thakis wrote:

>> Actually we already have a flag for that: `-DLLVM_EXTERNAL_PROJECTS` which is intended to be used to declare projects that aren't "known" (see https://llvm.org/docs/CMake.html )
>> Aren't you able to use this?
>
> We tried it a while ago and ran into a bunch of issues, see https://bugs.chromium.org/p/chromium/issues/detail?id=962988&q=LLVM_EXTERNAL_PROJECTS&can=2

Seems like this was fixed a couple of weeks after the last comment in this bug? https://reviews.llvm.org/D62289


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110016/new/

https://reviews.llvm.org/D110016



More information about the llvm-commits mailing list